Bug report: NRE on Bind when SystemType is not set up

[Jabberwok]

Hi there!

Now i have sources and can point exact lines in files where there are errors

Steps to reproduce:

Code: Select all

smppClient.Connect(config.HostName, config.Port);
pduBindResp bindResp = smppClient.Bind(config.SystemId, config.Password);

and SystemType is not set up.

in bindResp there will be CommandStatus.SMPPCLIENT_UNKNOWNERROR
and there will be OnError.

With sources it is obvious:
in class pduBind when you try to set SystemType to null it fails with NRE, since you try to check it's length.

i suggest to set SystemType of SmppClient to string.Empty not null, or throw more explaining exception.

[alt]

Thank you again, Jabberwok.
Fixed.

Everybody can download new build.

Who has source code license, please write me an email. I'll send update.
Don't forget to include purchasing information.